-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include sub-annual updates in annual_updates docs #3129
Conversation
…tes and other sub-annual data updates
…date all references to old name
…o match the rst file
Currently |
--- | ||
name: Integrate New Year of Data | ||
about: Check-list for integrating a new year of data | ||
title: '' | ||
labels: new-data | ||
assignees: '' | ||
|
||
--- | ||
|
||
### New year of data integration check-list: | ||
|
||
Based on the [Existing Data Updates Docs](https://catalystcoop-pudl.readthedocs.io/en/dev/dev/existing_data_updates.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole module is showing up as deleted and then re-added I think because the percentage content change is large enough that git doesn't recognize it as the same file? I tried to prevent this by running separate commits - one for the file changes and one for the file rename - but that didn't seem to help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's annoying but of well :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! i added two non-blocking suggestions but they are vv minor
--- | ||
name: Integrate New Year of Data | ||
about: Check-list for integrating a new year of data | ||
title: '' | ||
labels: new-data | ||
assignees: '' | ||
|
||
--- | ||
|
||
### New year of data integration check-list: | ||
|
||
Based on the [Existing Data Updates Docs](https://catalystcoop-pudl.readthedocs.io/en/dev/dev/existing_data_updates.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's annoying but of well :-/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3129 +/- ##
=====================================
Coverage 92.6% 92.6%
=====================================
Files 134 134
Lines 12577 12577
=====================================
+ Hits 11648 11649 +1
+ Misses 929 928 -1 ☔ View full report in Codecov by Sentry. |
…m/catalyst-cooperative/pudl into include-quarterly-updates-in-docs
The current documentation page for adding new data is called "Annual Updates". This is misleading because the page caters to all sorts of annual and sub-annual updates to existing data.
I changed the name to "Existing Data Updates" and updated some of the language in the documents to be more inclusive of all types of data updates.
Closes #3130