Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin SQLAlchemy<2.0 and allow pip 23 #2268

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Pin SQLAlchemy<2.0 and allow pip 23 #2268

merged 2 commits into from
Feb 3, 2023

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Feb 3, 2023

PR Overview

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 85.7% // Head: 85.7% // No change to project coverage 👍

Coverage data is based on head (ca6171b) compared to base (49e2e2f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2268   +/-   ##
=====================================
  Coverage   85.7%   85.7%           
=====================================
  Files         73      73           
  Lines       8997    8997           
=====================================
  Hits        7715    7715           
  Misses      1282    1282           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

interval: daily
interval: weekly
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, there have been a ton of version updates lately and it's kind of too much. Would really like to get the dependabot back to being able to merge into dev without human supervision if all the CI passes.

@@ -5,7 +5,7 @@ channels:
- defaults
dependencies:
# Used to set up the environment
- pip>=21,<23
- pip>=21,<24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New year. New pip.

Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zaneselvans zaneselvans merged commit 2c3aa67 into dev Feb 3, 2023
@zaneselvans zaneselvans deleted the pin-sqlalchemy branch February 3, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants