Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & simplify PR template formatting / language. #2181

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Jan 5, 2023

PR Overview

  • Comment out explanatory text so it doesn't gum up the PR.
  • Shorten bullets and format so they don't look janktastic.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.
  • All CI checks are passing. Run tests locally to debug failures

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 85.2% // Head: 85.2% // No change to project coverage 👍

Coverage data is based on head (f978556) compared to base (2e8fa5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2181   +/-   ##
=====================================
  Coverage   85.2%   85.2%           
=====================================
  Files         73      73           
  Lines       8555    8555           
=====================================
  Hits        7290    7290           
  Misses      1265    1265           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zaneselvans zaneselvans merged commit 9032de6 into main Jan 5, 2023
@zaneselvans zaneselvans deleted the update-pr-template branch January 5, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants