Make transform params stricter 2 #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns_ferc1 class attribute in Ferc1TableTransformParams to match RenameColumnsFerc1 class
aesharpe
added
ferc1
Codecov ReportBase: 85.5% // Head: 85.5% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #2177 +/- ##
=======================================
- Coverage 85.5% 85.5% -0.1%
=======================================
Files 73 73
Lines 8883 8882 -1
=======================================
- Hits 7600 7599 -1
Misses 1283 1283
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zaneselvans
requested changes
Jan 4, 2023
Comment on lines
-551
to
+552
| xbrl_instant=RenameColumns(), | ||
| xbrl_duration=RenameColumns(), | ||
| instant_xbrl=RenameColumns(), | ||
| duration_xbrl=RenameColumns(), |
There was a problem hiding this comment.
Eeek, we had this inconsistency with all of the actual parameters and it didn't cause any problems? That's kind of amazing.
…ts from TransformParams where extra=forbid is already an attribute
zaneselvans
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teeny tiny bb PR that adds the following code to the
TransformParamsclass:And fixes a parameter name that was flip-flopped:
xbrl_instantandxbrl_durationwere used as parameters in theFerc1TableTransformParamsclass when the actual parameters defined inRenameColumnsFerc1areinstant_xbrlandduration_xbrl. This PR flips them to reflect theRenameColumnsFerc1definition.