Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ferc1 record_id validation errors #2102

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Dec 1, 2022

we have one validation ferc1 test to check whether the record_id is unique, which doesn't apply to any of the column-> row reshaped tables. so we have to tell it to ignore those. + i added the shell of a table into the resources before it was ready so i disabled that one. we should use the transform params to find the tables to do this check on without having to enumerate each of these non-unique record_id tables

PR Checklist

Before requesting a review of your pull request, please make sure you've done the
following:

  • Merge the most recent version of dev (or the appropriate upstream branch) into
    your branch and resolved any merge conflicts. You may need to do this several
    times over the course of a PR as dev changes frequently.
  • Verify that all of the CI checks on your PR are passing. See
    Running Tests with Tox
    for details on how to run the full test suite locally if you need to debug a
    particular failure.
  • Ensure that the docstrings for any new modules, classes, functions, or methods are
    descriptive enough for developers and users to understand your code.
  • If you expanded data coverage or changed the outputs, ensure that the full
    data validation tests
    pass locally on a fresh DB.
  • If you've added new functions or classes, ensure that they have at least basic
    unit tests.
  • If you've added new analyses, make sure they include defensive sanity checks that
    will catch unexpected data issues.
  • Update the
    release notes
    to reflect your changes. Make sure to reference the PR and any related issues.
  • Do your own review of the PR. Add comments highlighting areas where you have
    questions you'd like reviewers to answer, known issues, solutions you're
    unsatisfied with, or other things that deserve special attention from the
    reviewer.

@cmgosnell cmgosnell marked this pull request as ready for review December 1, 2022 16:23
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 85.2% // Head: 85.2% // No change to project coverage 👍

Coverage data is based on head (ff3d426) compared to base (caa88a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2102   +/-   ##
=====================================
  Coverage   85.2%   85.2%           
=====================================
  Files         72      72           
  Lines       8279    8279           
=====================================
  Hits        7060    7060           
  Misses      1219    1219           
Impacted Files Coverage Δ
src/pudl/metadata/resources/ferc1.py 100.0% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmgosnell cmgosnell merged commit 8cd1134 into dev Dec 1, 2022
@cmgosnell cmgosnell deleted the ferc1_record_id_valition_fix branch December 1, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants