fix ferc1 record_id validation errors #2102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have one validation ferc1 test to check whether the record_id is unique, which doesn't apply to any of the column-> row reshaped tables. so we have to tell it to ignore those. + i added the shell of a table into the resources before it was ready so i disabled that one. we should use the transform params to find the tables to do this check on without having to enumerate each of these non-unique record_id tables
PR Checklist
Before requesting a review of your pull request, please make sure you've done the
following:
dev
(or the appropriate upstream branch) intoyour branch and resolved any merge conflicts. You may need to do this several
times over the course of a PR as
dev
changes frequently.Running Tests with Tox
for details on how to run the full test suite locally if you need to debug a
particular failure.
descriptive enough for developers and users to understand your code.
data validation tests
pass locally on a fresh DB.
unit tests.
will catch unexpected data issues.
release notes
to reflect your changes. Make sure to reference the PR and any related issues.
questions you'd like reviewers to answer, known issues, solutions you're
unsatisfied with, or other things that deserve special attention from the
reviewer.