Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Ref bug #1704

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Fix Github Ref bug #1704

merged 3 commits into from
Jun 23, 2022

Conversation

bendnorman
Copy link
Member

@bendnorman bendnorman commented Jun 22, 2022

I forgot to pass the updated git ref to the GCE VM which resulted in incorrectly named buckets. This PR fixes that issue and renames the variable in the GitHub action.

I'm going to rerun the action before I merge it in.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1704 (49bcb96) into main (25eabc3) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #1704   +/-   ##
=====================================
  Coverage   84.0%   84.0%           
=====================================
  Files         65      65           
  Lines       7181    7181           
=====================================
  Hits        6039    6039           
  Misses      1142    1142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25eabc3...49bcb96. Read the comment docs.

@bendnorman
Copy link
Member Author

Hmmm the 3.10 tests are failing on some imputation tests :/

@zaneselvans
Copy link
Member

zaneselvans commented Jun 23, 2022

Oh weird. I thought that was just a problem with the new numpy v1.23.0. This seems like a dependency update problem... We should figure out how to use lockfiles.

@bendnorman
Copy link
Member Author

The build-deploy-pudl branch was the most recent branch to get merged in which passed the tests in 3.10. These are the only changes in dependencies:

  • openssl 3.0.3 -> 3.0.4
  • xyzservices 2022.4.0 -> 2022.6.0

I don't think either of those libraries touch the failing tests.

@zaneselvans
Copy link
Member

It's numpy==1.23 causing the problem. main is only pinned to <2.0. Updating it now.

@zaneselvans
Copy link
Member

Weird that it would only be a numpy 1.23 + Python 3.10 problem though.

@zaneselvans
Copy link
Member

zaneselvans commented Jun 23, 2022

It looks like there are a couple of regressions in numpy that have come up this morning with the release. I think it's this one that's biting us.

@bendnorman
Copy link
Member Author

Ohhh I see thank you Zane!

@bendnorman bendnorman merged commit 885de11 into main Jun 23, 2022
@bendnorman bendnorman deleted the deploy-pudl-gitref-patch branch June 23, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants