-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Github Ref bug #1704
Fix Github Ref bug #1704
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1704 +/- ##
=====================================
Coverage 84.0% 84.0%
=====================================
Files 65 65
Lines 7181 7181
=====================================
Hits 6039 6039
Misses 1142 1142 Continue to review full report at Codecov.
|
Hmmm the 3.10 tests are failing on some imputation tests :/ |
Oh weird. I thought that was just a problem with the new numpy v1.23.0. This seems like a dependency update problem... We should figure out how to use lockfiles. |
The
I don't think either of those libraries touch the failing tests. |
It's |
Weird that it would only be a numpy 1.23 + Python 3.10 problem though. |
It looks like there are a couple of regressions in numpy that have come up this morning with the release. I think it's this one that's biting us. |
Ohhh I see thank you Zane! |
I forgot to pass the updated git ref to the GCE VM which resulted in incorrectly named buckets. This PR fixes that issue and renames the variable in the GitHub action.
I'm going to rerun the action before I merge it in.