Draft: add capacity mw to mcoe defaults and fix row counts in validation tests for eia tables #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katie-lamb
changed the title
katie-lamb
changed the title
katie-lamb
changed the title
zaneselvans
approved these changes
Jun 17, 2022
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to fix the MCOE and EIA validation tests that failed due to the newly added
date_mergehelper function. All I did was update the row counts and addcapacity_mwas a default column in MCOE. There are fewer rows in the EIA tables after replacingclean_merge_asofwithdate_mergebecause it fixed a little bug where rows from different years were being merged.