Clean up FIPS codes and use same method for ZIP codes #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a string cleaning function `pudl.helpers.zero_pad_numeric_string()` which can be used to standardize columns that are supposed to contain numeric codes of fixed width stored as strings. These codes are particularly susceptible to corruption through data type conversions. This function replaces the similar `zero_pad_zips` function, and can be used to clean up zip codes and FIPS codes that need to be all numeric and have leading zeroes to be valid. The FIPS codes being cleaned up here are the ones associated with coalmines reported in the `fuel_receipts_costs_eia923` table. Separately: Turn on processing of the eia860m by default.
Codecov Report
@@ Coverage Diff @@
## dev #1476 +/- ##
==========================================
+ Coverage 83.37% 83.37% +0.01%
==========================================
Files 64 64
Lines 6938 6935 -3
==========================================
- Hits 5784 5782 -2
+ Misses 1154 1153 -1
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
Removed derelict ZIP code columns from `fields.py` which had already been replaced in the renaming of EIA spreadsheet columns with standard `zip_code` and `zip_code_4`. Updated the pre-commit.ci configuration to skip local repo hooks that need additional software installed to run (nb-clear-outputs and pytest). Pre-commit autoupdates will also not be made as PRs against the `dev` branch. Closes #550
…ve/pudl into fips-check-constraint
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closed
4 tasks
* Warning filters to pytest configuration in tox.ini * More exception types for Zenodo tests to xfail on * Defensive assertion in zero_pad_numeric_string()
bendnorman
requested changes
Feb 18, 2022
This was referenced Mar 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a string cleaning function
pudl.helpers.zero_pad_numeric_string()which can beused to standardize columns that are supposed to contain numeric codes of fixed width
stored as strings. These codes are particularly susceptible to corruption through data
type conversions.
This function replaces the similar
zero_pad_zipsfunction, and can be used to clean upzip codes and FIPS codes that need to be all numeric and have leading zeroes to be
valid.
The FIPS codes being cleaned up here are the ones associated with coalmines reported in
the
fuel_receipts_costs_eia923table.Separately:
accumulated_depreciation_ferc1table, which we're no longer processing. Really this should be removed from the list of working tables.Settingsobjects.