Update generation_fuel_eia923 documentation with nuclear unit change. #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
reviewed
Nov 4, 2021
src/pudl/metadata/resources.py
Outdated
| @@ -198,7 +198,7 @@ | |||
| "sources": ["eia923"], | |||
| }, | |||
| "generation_fuel_eia923": { | |||
| "description": "Monthly electricity generation and fuel consumption reported for each combination of fuel and prime mover within a plant.", | |||
| "description": "Monthly electricity generation and fuel consumption reported for each combination of fuel and prime mover within a plant. This table does not include nuclear fuels because nuclear fuels are reported by generator unit where as non nuclear fuels are reported by plant_id, prime_mover and fuel_type. See the generation_fuel_nuclear_eia923 table for nuclear fuel data.", | |||
There was a problem hiding this comment.
Saying "nuclear fuels" seems a bit odd to me here. It's really electricity generation and fuel consumption.
Codecov Report
@@ Coverage Diff @@
## dev #1323 +/- ##
==========================================
+ Coverage 82.40% 83.08% +0.68%
==========================================
Files 55 56 +1
Lines 6626 6867 +241
==========================================
+ Hits 5460 5705 +245
+ Misses 1166 1162 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split the nuclear units out from
generation_fuel_eia923in #1296 because nuclear fuels are reported at the generation unit level and non-nuclear unit fuels are reported at the plant, prime mover, and fuel level. Some users were confused by this so I included this explanation in thegeneration_fuel_eia923data dictionary docs.