Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plant_id_pudl to small generators field #1293

Merged
merged 7 commits into from
Oct 22, 2021
Merged

Conversation

aesharpe
Copy link
Member

verrrrryyy small bitty changes to add the plant_id_pudl field to the small generators table and by consequence the all_plants_ferc1 table

@aesharpe aesharpe added the ferc1 Anything having to do with FERC Form 1 label Oct 15, 2021
@aesharpe aesharpe self-assigned this Oct 15, 2021
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1293 (4c0cbc6) into dev (7c84500) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1293   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          55       55           
  Lines        6470     6470           
=======================================
  Hits         5243     5243           
  Misses       1227     1227           
Impacted Files Coverage Δ
src/pudl/output/ferc1.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c84500...4c0cbc6. Read the comment docs.

…e. Because it has two plant_name columns it gets confusing.
…database:

Initially I merged the small generators ferc1 table with the pudl utility and plant ids using plant_name_original. However, Zane changed this to plant_name_ferc1 so we don't actually have to specify this caveat in the doc strings or the merge
@zaneselvans zaneselvans merged commit d07988b into dev Oct 22, 2021
@zaneselvans zaneselvans deleted the add-pudl-id-to-small-gens branch October 22, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ferc1 Anything having to do with FERC Form 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants