-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plant_id_pudl to small generators field #1293
Conversation
…udl and utility_id_pudl ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
@@ Coverage Diff @@
## dev #1293 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 55 55
Lines 6470 6470
=======================================
Hits 5243 5243
Misses 1227 1227
Continue to review full report at Codecov.
|
…e. Because it has two plant_name columns it gets confusing.
…st-cooperative/pudl into add-pudl-id-to-small-gens
…database: Initially I merged the small generators ferc1 table with the pudl utility and plant ids using plant_name_original. However, Zane changed this to plant_name_ferc1 so we don't actually have to specify this caveat in the doc strings or the merge
verrrrryyy small bitty changes to add the
plant_id_pudl
field to the small generators table and by consequence theall_plants_ferc1
table