Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the data package cruft #1267

Merged
merged 5 commits into from
Oct 1, 2021
Merged

remove the data package cruft #1267

merged 5 commits into from
Oct 1, 2021

Conversation

cmgosnell
Copy link
Member

Closes #1211

@cmgosnell cmgosnell linked an issue Oct 1, 2021 that may be closed by this pull request
Remove residual datapackage infrastructure #1211
Closed
7 tasks
@codecov
Copy link

codecov bot commented Oct 1, 2021 •
edited
Loading

Codecov Report

Merging #1267 (129375e) into dev (2567b2a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1267      +/-   ##
==========================================
+ Coverage   81.22%   81.23%   +0.02%     
==========================================
  Files          54       54              
  Lines        6389     6389              
==========================================
+ Hits         5189     5190       +1     
+ Misses       1200     1199       -1
Impacted Files Coverage Δ
src/pudl/analysis/timeseries_cleaning.py 88.84% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2567b2a...129375e. Read the comment docs.

@zaneselvans
Copy link
Member

I think there are some additional references to some of these modules in .pre-commit-config.yaml and .coveragerc and docs/conf.py that should be removed as well.

@cmgosnell
remove the dangling data package references..
d4320ef 
not sure why these weren't showing up when i did a package-wide search 
but ya know.
@cmgosnell
duh. remove the harvesting mucking... bc it doesn't belong here.
8a5e3ea 
.... i was working on two things at once and this one got caught in the 
cross wires.
zaneselvans
zaneselvans requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny oops in there. but mostly 🎉 yay 🎉

docs/conf.py Show resolved Hide resolved
@zaneselvans zaneselvans merged commit 11d95c4 into dev Oct 1, 2021
@zaneselvans zaneselvans deleted the bye_data_pkg_bye branch October 1, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneselvans zaneselvans zaneselvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove residual datapackage infrastructure
2 participants
@cmgosnell @zaneselvans