Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up Output Time Series #454

Open
cmgosnell opened this issue Oct 15, 2019 · 0 comments
Open

Clean Up Output Time Series #454

cmgosnell opened this issue Oct 15, 2019 · 0 comments
Labels
data-repair Interpolating or extrapolating data that we don't actually have. epic Any issue whose primary purpose is to organize other issues into a group. output Exporting data from PUDL into other platforms or interchange formats. time what even is time. fixing and changing the way in which PUDL data deals with time

Comments

@cmgosnell
Copy link
Member

cmgosnell commented Oct 15, 2019 •
edited by zaneselvans
Loading

This epic collects together a bunch of issues related to how the output routines deal with time series, start/end dates, NA values, etc., which should be addressed together.
@cmgosnell cmgosnell added data-repair Interpolating or extrapolating data that we don't actually have. output Exporting data from PUDL into other platforms or interchange formats. epic Any issue whose primary purpose is to organize other issues into a group. labels Oct 15, 2019
@zaneselvans zaneselvans changed the title output time series cleanup Clean Up Output Time Series Oct 15, 2019
zaneselvans added a commit that referenced this issue Oct 18, 2019
@zaneselvans
Replace assert statements with real exceptions
64a3784 
I was feeling brain dead this Friday PM so I did a mindless cleanup task.

Replaced all of the remaining `assert` statements that we were using for
error checking with `raise ValueError()` and improved the error messages
that were being raised.

Exceptions:
 * `pudl.helpers.is_annual()` which is a mess, and needs to be replaced
   entirely along with a bunch of other stuff as part of #454
 * `pudl.workspace.datastore` assertions, which are also (like that
   whole module...) a mess, to be replaced wholesale soon under #182.

Closes #281
@cmgosnell cmgosnell added the time what even is time. fixing and changing the way in which PUDL data deals with time label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data-repair Interpolating or extrapolating data that we don't actually have. epic Any issue whose primary purpose is to organize other issues into a group. output Exporting data from PUDL into other platforms or interchange formats. time what even is time. fixing and changing the way in which PUDL data deals with time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmgosnell