Seatbelts do not drop seat belt item when uninstalled, but range of synthetic fabric

[Relgar]

Describe the bug

Some recipes call for seatbelt items - however, these have stopped being uninstalled as seatbelt 'items'. If you disassemble a seat belt from a vehicle it will turn straight into it's disassembly components. Compare this with mufflers which disassemble correctly and drop a muffler.

Steps To Reproduce

1. Spawn a vehicle
2. Remove seatbelts
3. Notice you get 0-3 synfab instead of a seatbelt item

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.3803 (22H2)
• Game Version: 36a2fd9 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: []
• Mods loaded: [
  Bright Nights [bn],
  Disable NPC Needs [no_npc_food],
  Simplified Nutrition [novitamins],
  No Rail Stations [No_Rail_Stations],
  Prevent Zombie Revivication [no_reviving_zombies],
  Limit Fungal Growth [limit_fungal_growth],
  Aftershock [aftershock],
  Mythical Martial Arts [MMA],
  No Filthy Clothing [no_filthy_clothing],
  No Lifting Reqs [disable_lifting],
  SpeedyDex [speedydex],
  Stats Through Kills [stats_through_kills],
  Stats Through Skills [StatsThroughSkills]
  ]

Additional context

May be related to #3489 as JSON code has not changed in months.

[RoyalFox2140]

I am convinced it is related to #3489 because I found a version before 0.5 stable where I get seatbelts. Game report is below.

• OS: Windows
  • OS Version: 10.0.19045.3448 (22H2)
• Game Version: 7e70561 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: English [en_US]
• Mods loaded: [
  Bright Nights [bn],
  Elevated bridges [elevated_bridges],
  Craftable Gun Pack [craftgp],
  Alternative Map Key [alt_map_key],
  Fuji's Military Profession Pack [fuji_mpp],
  Arcana and Magic Items [Arcana],
  Craftable Bullet Casings [CasingCrafting],
  MST Extra [MST_Extra],
  Tankmod: Revived [Tankmod_Revived],
  Essence 2200 BN [Essence2200_BN],
  Essence 2200 Tweaks [FoxTweaks],
  Nonperishable Overhaul [Nonperishable_Overhaul],
  No Addictions [No_Addictions],
  Limit Fungal Growth [limit_fungal_growth],
  Disable NPC Needs [no_npc_food]
  ]

[RoyalFox2140]

Tested on 0.5 Stable. You remove the broken I I seatbelt, I gained no items on removing the seatbelt.

• OS: Windows
  • OS Version: 10.0.19045.3448 (22H2)
• Game Version: 0.5 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: English [en_US]
• Mods loaded: [
  Bright Nights [bn],
  Craftable Gun Pack [craftgp],
  Alternative Map Key [alt_map_key],
  Craftable Bullet Casings [CasingCrafting],
  MST Extra [MST_Extra],
  Essence 2200 BN [Essence2200_BN],
  Essence 2200 Tweaks [FoxTweaks],
  Nonperishable Overhaul [Nonperishable_Overhaul],
  No Addictions [No_Addictions],
  Limit Fungal Growth [limit_fungal_growth],
  Disable NPC Needs [no_npc_food],
  Simplified Nutrition [novitamins],
  Mining Mod [Mining_Mod],
  Rural-Only Mapgen [ruralbiome],
  No Monsters [Only_Wildlife]
  ]

[Relgar]

Almantuxas outlined the mechanism of the bug on the Discord here.

[scarf005]

to re-iterate from discord:

Cataclysm-BN/src/veh_interact.cpp

Lines 3267 to 3292 in d05c6a9

	if( broken ) {
	p.add_msg_if_player( _( "You remove the broken %1$s from the %2$s." ),
	veh->part( vehicle_part ).name(), veh->name );
	} else {
	p.add_msg_if_player( _( "You remove the %1$s from the %2$s." ),
	veh->part( vehicle_part ).name(), veh->name );
	}
	if( !broken ) {
	resulting_items.push_back( veh->part( vehicle_part ).properties_to_item() );
	for( const auto &sk : vpinfo.install_skills ) {
	// removal is half as educational as installation
	p.practice( sk.first, veh_utils::calc_xp_gain( vpinfo, sk.first, p ) / 2 );
	}
	} else {
	auto pieces = veh->part( vehicle_part ).pieces_for_broken_part();
	resulting_items.insert( resulting_items.end(), std::make_move_iterator( pieces.begin() ),
	std::make_move_iterator( pieces.end() ) );
	}
	if( veh->part_count() < 2 ) {
	p.add_msg_if_player( _( "You completely dismantle the %s." ), veh->name );
	p.activity->set_to_null();
	here.destroy_vehicle( veh );
	here.reset_vehicle_cache( );

Cataclysm-BN/src/itype.cpp

Lines 52 to 55 in 578117a

	int itype::damage_max() const
	{
	return count_by_charges() ? 0 : damage_max_;
	}

for some reason damage_max for count-by-charge items is always 0.

[Relgar]

This may be because damage is no longer tracked per item. Which becomes awkward if you're tracking say damage to 50 bullets. The problem also becomes that you can't just make something damage a stack like XX Rope (6) either.

[scarf005]

i guess we'd need to implement proper damage sharing logic for stackables. this gonna be big...

[Relgar]

Depends - how does damage currently track for 'normal' stackables like coins or ammo? Can it get destroyed?

[seerdecker]

Also impacted by this bug in 0.5.2.