Various debugging-related log statements #902
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I want this merged in (it does clutter up code), but I find myself reinventing many of these log statements over and over while figuring out type resolution issues. In the meantime, I've been keeping development branches with my open PRs merged in - see apiology/solargraph:YYYY-MM-DD. I can merge this in to those and have the improvements even we decide not to clutter up master. |
|
Perf wise, the slowdown from the statements seems in the noise - typed-level typechecking of solargraph's code takes 23-26 seconds of wall clock on my machine either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.