Test plugins with v0.58.0 #1139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Want to try again? |
Contributor
|
Verified in a dummy PR that this should pass on master now: I lifted the upper bound entirely in solargraph-rails. |
Contributor
|
...except I merged the latest castwide/master in and now it's not working lol Looking here |
Owner
Author
Contributor
|
Ah, I think I see what's going on - let me push out another solargraph-rails PR to address. Sorry for the trouble! |
Contributor
|
This should fix - will merge once the tests pass: iftheshoefritz/solargraph-rails#186 |
Contributor
|
Merged - trying again here: https://github.com/apiology/solargraph/actions/runs/20641863025/job/59276502290 |
Owner
Author
|
All checks pass on master now, so we can close this one. Thanks again, @apiology! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the gem version broke the solargraph-rails tests in CI. This is a temporary stopgap to make sure the tests still pass before release.