-
-
Notifications
You must be signed in to change notification settings - Fork 165
Make 'self' types concrete while typechecking arguments #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
apiology
wants to merge
22
commits into
castwide:master
from
apiology:handle_more_typechecking_self_situations
Closed
Make 'self' types concrete while typechecking arguments #1050
apiology
wants to merge
22
commits into
castwide:master
from
apiology:handle_more_typechecking_self_situations
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2025
…cking_self_situations
YARD-parsed namespaces weren't correctly setting their gates, leading to unresolved types from methods.
1) Prefer closures with more gates, to maximize compatibility 2) Look at basename of location, to make choice consistent
Found in the Solargraph::Pin::DelegatedMethod class in strong typechecking in #12
…another_ambiguous_type
…cking_self_situations
…nother_ambiguous_type
…ore_typechecking_self_situations
…cking_self_situations
This was referenced Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of similar strong level typechecking errors on the Solargraph codebase.
Typical example:
Depends on and includes: