Improve typechecking of generics #1012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2025
…ric_typechecking_improvements
apiology
commented
Jan 4, 2026
| end | ||
|
|
||
| # @return [Hash{String => Array<String>}] | ||
| # @return [Hash{String => Array<Pin::Reference::Include>}] |
Contributor
Author
There was a problem hiding this comment.
The better typechecking found some issues in the annotations!
apiology
commented
Jan 4, 2026
| elsif return_type.erased_version_of?(other.return_type) | ||
| other.return_type | ||
| elsif other.return_type.erased_version_of?(return_type) | ||
| return_type |
Contributor
Author
There was a problem hiding this comment.
Help more precise type definitions make it through as the pins we typecheck against
apiology
commented
Jan 5, 2026
| generic_values = type.all_params.map(&:to_s) | ||
| include_pin = Solargraph::Pin::Reference::Include.new( | ||
| name: decl.name.relative!.to_s, | ||
| name: type.rooted_name, |
Contributor
Author
There was a problem hiding this comment.
build_type takes care of any root information we have available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of files changed here, but the vast majority are added specs and fixed annotations, most from the improvements in this PR.
This is a rewrite of the current 'can I use this type here' code. In particular, we now in strong mode validate the type parameters of variable assignment and parameters, with the following exceptions:
Info on each check:
Depends on:
Includes for convenience: