-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for readable lowercase topics #2393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
============================================
+ Coverage 66.12% 66.40% +0.27%
- Complexity 1405 1408 +3
============================================
Files 207 207
Lines 11724 11820 +96
Branches 1473 1476 +3
============================================
+ Hits 7753 7849 +96
+ Misses 3461 3460 -1
- Partials 510 511 +1 ☔ View full report in Codecov by Sentry. |
Runs with ONNX: target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics msmarco-v1-passage-dev -output runs/run.msmarco-passage.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics msmarco-v1-passage-dev -encoder SpladePlusPlusEnsembleDistil -output runs/run.msmarco-passage.splade-pp-ed.onnx.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics msmarco-v1-passage-dev -encoder CosDprDistil -output runs/run.msmarco-passage.cos-dpr-distil.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics msmarco-v1-passage-dev -encoder CosDprDistil -output runs/run.msmarco-passage.cos-dpr-distil-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics msmarco-v1-passage-dev -encoder BgeBaseEn15 -output runs/run.msmarco-passage.bge.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics msmarco-v1-passage-dev -encoder BgeBaseEn15 -output runs/run.msmarco-passage.bge-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.bm25.txt
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.splade-pp-ed.onnx.txt
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.cos-dpr-distil.onnx.txt
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.cos-dpr-distil-quantized.onnx.txt
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.bge.onnx.txt
target/appassembler/bin/trec_eval -c -M 10 -m recip_rank tools/topics-and-qrels/qrels.msmarco-passage.dev-subset.txt runs/run.msmarco-passage.bge-quantized.onnx.txt
target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics dl19-passage -output runs/run.dl19.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics dl19-passage -encoder SpladePlusPlusEnsembleDistil -output runs/run.dl19.splade-pp-ed.onnx.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics dl19-passage -encoder CosDprDistil -output runs/run.dl19.cos-dpr-distil.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics dl19-passage -encoder CosDprDistil -output runs/run.dl19.cos-dpr-distil-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics dl19-passage -encoder BgeBaseEn15 -output runs/run.dl19.bge.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics dl19-passage -encoder BgeBaseEn15 -output runs/run.dl19.bge-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.bm25.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.splade-pp-ed.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.cos-dpr-distil.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.cos-dpr-distil-quantized.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.bge.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl19-passage.txt runs/run.dl19.bge-quantized.onnx.txt
target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics dl20-passage -output runs/run.dl20.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics dl20-passage -encoder SpladePlusPlusEnsembleDistil -output runs/run.dl20.splade-pp-ed.onnx.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics dl20-passage -encoder CosDprDistil -output runs/run.dl20.cos-dpr-distil.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics dl20-passage -encoder CosDprDistil -output runs/run.dl20.cos-dpr-distil-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics dl20-passage -encoder BgeBaseEn15 -output runs/run.dl20.bge.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics dl20-passage -encoder BgeBaseEn15 -output runs/run.dl20.bge-quantized.onnx.txt -threads 16 -efSearch 1000
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.bm25.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.splade-pp-ed.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.cos-dpr-distil.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.cos-dpr-distil-quantized.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.bge.onnx.txt
target/appassembler/bin/trec_eval -m ndcg_cut.10 -c tools/topics-and-qrels/qrels.dl20-passage.txt runs/run.dl20.bge-quantized.onnx.txt Results:
|
Runs with pre-encoded queries: target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics msmarco-v1-passage-dev -output runs/run.msmarco-passage.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics msmarco-v1-passage-dev-splade-pp-ed -output runs/run.msmarco-passage.splade-pp-ed.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics msmarco-v1-passage-dev-cos-dpr-distil -output runs/run.msmarco-passage.cos-dpr-distil.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics msmarco-v1-passage-dev-cos-dpr-distil -output runs/run.msmarco-passage.cos-dpr-distil-quantized.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics msmarco-v1-passage-dev-bge-base-en-v1.5 -output runs/run.msmarco-passage.bge.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics msmarco-v1-passage-dev-bge-base-en-v1.5 -output runs/run.msmarco-passage.bge-quantized.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics dl19-passage -output runs/run.dl19.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics dl19-passage-splade-pp-ed -output runs/run.dl19.splade-pp-ed.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics dl19-passage-cos-dpr-distil -output runs/run.dl19.cos-dpr-distil.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics dl19-passage-cos-dpr-distil -output runs/run.dl19.cos-dpr-distil-quantized.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics dl19-passage-bge-base-en-v1.5 -output runs/run.dl19.bge.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics dl19-passage-bge-base-en-v1.5 -output runs/run.dl19.bge-quantized.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchCollection -index msmarco-v1-passage -topics dl20-passage -output runs/run.dl20.bm25.txt -threads 16 -bm25
target/appassembler/bin/SearchCollection -index msmarco-v1-passage-splade-pp-ed -topics dl20-passage-splade-pp-ed -output runs/run.dl20.splade-pp-ed.txt -threads 16 -impact -pretokenized
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil -topics dl20-passage-cos-dpr-distil -output runs/run.dl20.cos-dpr-distil.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-cos-dpr-distil-quantized -topics dl20-passage-cos-dpr-distil -output runs/run.dl20.cos-dpr-distil-quantized.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5 -topics dl20-passage-bge-base-en-v1.5 -output runs/run.dl20.bge.txt -threads 16 -efSearch 1000
target/appassembler/bin/SearchHnswDenseVectors -index msmarco-v1-passage-bge-base-en-v1.5-quantized -topics dl20-passage-bge-base-en-v1.5 -output runs/run.dl20.bge-quantized.txt -threads 16 -efSearch 1000 Results:
|
MXueguang
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For something like:
We can refer to
msmarco-passage-dev
instead of the full EnumMSMARCO_PASSAGE_DEV_SUBSET
.