Fix BGE maxlen issue and add maxlen test cases for splade-pp-ed and bge #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArthurChen189
commented
Feb 21, 2024
ArthurChen189
commented
- fix BGE maxlen issue by restricting maxlen to 512
- add maxlen test cases (i.e., long input query) for splade-pp-ed and bge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
============================================
+ Coverage 65.74% 65.96% +0.21%
- Complexity 1400 1405 +5
============================================
Files 207 207
Lines 11666 11666
Branches 1473 1473
============================================
+ Hits 7670 7695 +25
+ Misses 3486 3461 -25
Partials 510 510 ☔ View full report in Codecov by Sentry. |
lintool
approved these changes
Feb 21, 2024
lintool
added a commit
that referenced
this pull request
Feb 22, 2024
+ maxlen issue with ONNX fixed in #2387 + this PR simply copies scores from the non-ONNX versions, will circle back and readjust scores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.