Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splade-pp-ed beir regression files #2270

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

justram
Copy link
Member

@justram justram commented Nov 24, 2023

  • added yaml/template/docs
  • modified README.md
  • tested with the collection at /mnt/users/j587yang/collections/beir-v1.0.0
  • related PR

@justram justram requested review from lintool and cadurosar November 24, 2023 05:10
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae498aa) 62.95% compared to head (14c9022) 62.96%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2270   +/-   ##
=========================================
  Coverage     62.95%   62.96%           
- Complexity     1271     1272    +1     
=========================================
  Files           196      196           
  Lines         11418    11418           
  Branches       1452     1452           
=========================================
+ Hits           7188     7189    +1     
  Misses         3708     3708           
+ Partials        522      521    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool
Copy link
Member

lintool commented Nov 24, 2023

This is what we have right now:

% ls src/main/resources/regression/msmarco-* | grep splade
src/main/resources/regression/msmarco-passage-distill-splade-max.yaml
src/main/resources/regression/msmarco-passage-splade-distil-cocodenser-medium.yaml
src/main/resources/regression/msmarco-passage-splade-pp-ed-onnx.yaml
src/main/resources/regression/msmarco-passage-splade-pp-ed.yaml
src/main/resources/regression/msmarco-passage-splade-pp-sd-onnx.yaml
src/main/resources/regression/msmarco-passage-splade-pp-sd.yaml
src/main/resources/regression/msmarco-v2-passage-splade-pp-ed.yaml
src/main/resources/regression/msmarco-v2-passage-splade-pp-sd.yaml

Let's be consistent and call it splade-pp-ed?

@justram
Copy link
Member Author

justram commented Nov 24, 2023

model renamed

@lintool
Copy link
Member

lintool commented Nov 24, 2023

Awesome, thanks @justram for this!

Let's get this merged in, and I'll run tests on my end.

@justram
Copy link
Member Author

justram commented Nov 24, 2023

Happy to help!
Pre-encoded documents can be found in the following directory: tjena:/mnt/users/j587yang/collections/beir-v1.0.0/splade-pp-ed. Need to transfer these documents to the respective servers such as orca, tuna, and others before initiating the regression process.

@lintool
Copy link
Member

lintool commented Nov 24, 2023

Happy to help! Pre-encoded documents can be found in the following directory: tjena:/mnt/users/j587yang/collections/beir-v1.0.0/splade-pp-ed. Need to transfer these documents to the respective servers such as orca, tuna, and others before initiating the regression process.

yup, will do!

@justram justram merged commit d88446c into castorini:master Nov 24, 2023
3 checks passed
@justram justram deleted the splade-pp-ed_beir branch November 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants