Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TREC COVID round 3 baseline runs #1230

Merged
merged 6 commits into from
May 27, 2020
Merged

TREC COVID round 3 baseline runs #1230

merged 6 commits into from
May 27, 2020

Conversation

lintool
Copy link
Member

@lintool lintool commented May 26, 2020

Please actually run the commands to confirm that the results are replicable.

@andrewyates @seanmacavaney can you also try to replicate if you have a few minutes?

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1230 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1230      +/-   ##
============================================
+ Coverage     48.36%   48.38%   +0.01%     
- Complexity      740      741       +1     
============================================
  Files           147      147              
  Lines          8555     8555              
  Branches       1213     1213              
============================================
+ Hits           4138     4139       +1     
  Misses         4078     4078              
+ Partials        339      338       -1     
Impacted Files Coverage Δ Complexity Δ
...java/io/anserini/ltr/feature/CountBigramPairs.java 90.90% <0.00%> (+1.29%) 34.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37704db...ea5d53b. Read the comment docs.

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rodrigonogueira4
Copy link
Member

LGTM!

@lintool, I've successfully replicated all results.

Copy link
Contributor

@lukuang lukuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I was able to replicate the numbers for round 3

Copy link
Member

@edwinzhng edwinzhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced as well 👍

@lintool lintool merged commit a5bdb32 into master May 27, 2020
@lintool lintool deleted the round3-runs branch May 27, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants