Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 20-newsgroup lucene index guide #1203

Merged
merged 10 commits into from
May 16, 2020
Merged

Add 20-newsgroup lucene index guide #1203

merged 10 commits into from
May 16, 2020

Conversation

x65han
Copy link
Member

@x65han x65han commented May 16, 2020

  • Add a README on how to obtain Lucene index for 20-newsgroup dataset along with helper script

@x65han x65han requested a review from lintool May 16, 2020 17:46
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #1203 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1203      +/-   ##
============================================
+ Coverage     48.10%   48.16%   +0.05%     
- Complexity      727      731       +4     
============================================
  Files           147      147              
  Lines          8527     8527              
  Branches       1211     1211              
============================================
+ Hits           4102     4107       +5     
+ Misses         4085     4081       -4     
+ Partials        340      339       -1     
Impacted Files Coverage Δ Complexity Δ
...anserini/ltr/feature/base/PMIFeatureExtractor.java 86.53% <0.00%> (+1.92%) 13.00% <0.00%> (+1.00%)
...java/io/anserini/ltr/feature/CountBigramPairs.java 70.12% <0.00%> (+5.19%) 26.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5407b03...5f2d5fd. Read the comment docs.

docs/20newsgroup.md Outdated Show resolved Hide resolved
docs/20newsgroup.md Outdated Show resolved Hide resolved
docs/20newsgroup.md Outdated Show resolved Hide resolved
docs/20newsgroup.md Outdated Show resolved Hide resolved
docs/20newsgroup.md Outdated Show resolved Hide resolved
@x65han x65han requested a review from lintool May 16, 2020 20:02
@x65han
Copy link
Member Author

x65han commented May 16, 2020

Resolved all. Not sure if I got everything right. Let me know, please. Thanks!

Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise looks good.

src/main/python/20newsgroup/prune_and_merge.py Outdated Show resolved Hide resolved
docs/experiments-20newsgroups.md Outdated Show resolved Hide resolved
@x65han x65han requested a review from lintool May 16, 2020 20:24
@x65han x65han merged commit 6315c0b into master May 16, 2020
@lintool lintool deleted the johnson branch May 16, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants