-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ANNSearcher class for easier ANN usage from code #1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
============================================
+ Coverage 45.00% 45.35% +0.34%
- Complexity 660 675 +15
============================================
Files 135 136 +1
Lines 8039 8092 +53
Branches 1149 1160 +11
============================================
+ Hits 3618 3670 +52
+ Misses 4098 4095 -3
- Partials 323 327 +4
Continue to review full report at Codecov.
|
lintool
reviewed
Apr 4, 2020
lintool
reviewed
Apr 4, 2020
@tteofili bunch of comments for you! |
lintool
requested changes
Apr 4, 2020
lintool
approved these changes
Apr 4, 2020
crystina-z
pushed a commit
to crystina-z/anserini
that referenced
this pull request
Oct 28, 2022
sync unicoil topics in anserini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes involve creation of
ANNSearcher
class (similar to whatSimpleSearcher
does) for easier execution of approximate nearest neighbor search from code (e.g. from pyserini).The PR also includes some minor changes to the original ANN code for eventually storing full vectors within the index (instead of requiring the text embedding model to be available at search time, as it is today).
Finally some minor adjustments to defaults for ANN analyzers, to make them consistent over the codebase.