-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make classes sealed, methods static & avoid array allocations where possible, dispose disposable, other optimizations & clean up usings #687
base: master
Are you sure you want to change the base?
Conversation
…ossible, dispose disposable, other optimizations & clean up usings
Hi @Henr1k80 and thanks for contributing! ✨ A couple points:
So I think it would be great if you could split up this PR into several ones, each dealing with one specific aspect so that we can deal with them separately
OK for you to proceed like this? If so, I'd be closing this PR in favor of the upcoming one(s). |
Hi @stakx
I have been very meticulous securing that there are no changes to the public contract, only internal & private classes have been made sealed and static. There are no changes to the unit tests, an indication of nothing changed. |
@Henr1k80, see the changes in the My above points and the question re: whether to proceed as suggested still stand. |
…o a new major version
@stakx ok, I understand your concerns and have removed the changes that affect the |
I was surprised to see how popular this package is and I would like to try reduce the carbon impact of it.
It might not be directly measurable, but the compound impact of all the executions hopefully makes a difference 🤞🏻
Where possible:
Dispose disposable
Other minor optimizations™®©
Clean up
using
sThere should be no breaking changes, unless you do reflection hacks and that should not be a supported use case.