Update FrameworkDisplayName in ref/ contract files
#641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the .NET compilers previously left this custom attribute property empty, but have now started setting it.
Our `PublicApi` verification test passes on AppVeyor while it fails on GitHub Actions. One difference between the two is that AppVeyor uses v7 of the .NET SDK, while GitHub Actions uses v6. Installing both .NET 6 and 7 will hopefully resolve the `PublicApi` test failure with GitHub Actions builds.
Member
Author
|
Took me a moment to figure out what went wrong here: apparently, .NET tooling started to provide a value for |
stakx
force-pushed
the
update-ref-contract-files
branch
from
a660274 to
3f7a499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the .NET compilers previously left this custom attribute property empty, but have now started setting it.