feat: use unstructured runtime objects instead of Karpenter types #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijusn-cast
force-pushed
the
pijusn/remove-karpenter-dependency
branch
from
506df90
to
f2bfb33
Compare
pijusn-cast
force-pushed
the
pijusn/remove-karpenter-dependency
branch
from
f2bfb33
to
8abc5e0
Compare
pijusn-cast
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
vladklokun,
linkas45,
laimonasr and
kasia-kujawa
as code owners
mikenorgate
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use unstructured data type instead of Karpenter types. For this, I had to switch from using reflection to using object kind to differentiate between them.
Note: I'm opening this PR but we need to still fully fix up
Deltalogic (see #196)