Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Python SDK page updated. #1431

Merged
merged 18 commits into from
Apr 18, 2024
Merged

1. Python SDK page updated. #1431

merged 18 commits into from
Apr 18, 2024

Conversation

asladeofgreen
Copy link
Contributor

@asladeofgreen asladeofgreen commented Apr 16, 2024

What does this PR fix/introduce?

Obsolete Python SDK page content.

Closes #1430

Additional context

Simplified page by pointing directly to dedicated How To pages within SDK repo itself.

Checklist

(Delete any that aren't relevant)

  • Docs are successfully building - yarn install && yarn run build.
  • All external links have been verified with yarn run check:externals.
  • My changes follow the Casper docs style guidelines.

Reviewers

@ipopescu

Copy link

github-actions bot commented Apr 16, 2024

Copy link
Collaborator

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few minor nits. Removing the question marks seems cleaner.

source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
@ipopescu
Copy link
Collaborator

The build will be fixed with this PR:
#1429

asladeofgreen and others added 17 commits April 18, 2024 11:48
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
Co-authored-by: Iulia Popescu <ipopescu@users.noreply.github.com>
@asladeofgreen
Copy link
Contributor Author

@ipopescu Incorporated your nits !

@ipopescu
Copy link
Collaborator

Great, then I will merge it.

@ipopescu ipopescu merged commit 2db1a14 into dev Apr 18, 2024
11 checks passed
@ipopescu ipopescu deleted the issues/1430 branch April 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete Python SDK content
2 participants