fix: improve app store install flow diagnostics - #97
Merged
hsluoyz merged 1 commit intoJul 8, 2026
Merged
Conversation
bugkeep
force-pushed
the
fix/app-store-install-diagnostics-upstream
branch
from
July 8, 2026 15:53
9d43a5f to
862e19b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When App Store installs failed, the product often surfaced low-context messages such as resource-not-ready or generic wait errors. That made it hard to tell whether the failure came from chart defaults, missing cluster capabilities, or a real Helm/runtime error.
This PR previously also included recommended install value changes. Those product-behavior defaults have been removed from this PR so the change stays focused on diagnostics.
Root Cause
The install path did not provide enough normalized diagnostics back to the UI and could leak sensitive repository credentials in some error messages. The stream client also needed focused coverage for terminal install states such as
ABORTEDandDONE.Fix
Validation
go test ./storeyarn test --runTestsByPath src/backend/HelmBackend.test.js --watchAll=false, but this repo has notestscript inweb/package.jsonmasterOCR Notes
OCR initially flagged that this PR mixed diagnostics with recommended values behavior. The recommended values files and
js-yamldependency were removed from this PR.OCR also flagged credential redaction edge cases. This PR now covers userinfo redaction, common sensitive query keys, token-only userinfo fallback, malformed query fallback, and host:port false-positive avoidance.
OCR still recommends Go unit tests for the redaction helpers. The local repository publishing rule currently says not to upload
*_test.gofiles, so no Go test file is included here.Scope
This PR improves install diagnostics, error redaction, and stream-state coverage. It does not change chart default values, service exposure defaults, storage, DNS, ingress, or platform bootstrap behavior.