Skip to content

fix: improve app store install flow diagnostics - #97

Merged
hsluoyz merged 1 commit into
casosorg:masterfrom
bugkeep:fix/app-store-install-diagnostics-upstream
Jul 8, 2026
Merged

fix: improve app store install flow diagnostics#97
hsluoyz merged 1 commit into
casosorg:masterfrom
bugkeep:fix/app-store-install-diagnostics-upstream

Conversation

@bugkeep

@bugkeep bugkeep commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Problem

When App Store installs failed, the product often surfaced low-context messages such as resource-not-ready or generic wait errors. That made it hard to tell whether the failure came from chart defaults, missing cluster capabilities, or a real Helm/runtime error.

This PR previously also included recommended install value changes. Those product-behavior defaults have been removed from this PR so the change stays focused on diagnostics.

Root Cause

The install path did not provide enough normalized diagnostics back to the UI and could leak sensitive repository credentials in some error messages. The stream client also needed focused coverage for terminal install states such as ABORTED and DONE.

Fix

  • improve Helm install diagnostics so wait failures are easier to interpret
  • redact repository credentials from Helm/chart loading errors, including URL userinfo and common credential query parameters
  • add fallback redaction for malformed URLs that cannot be parsed normally
  • keep App Store install values unchanged in this PR
  • add frontend coverage for Helm install stream terminal states

Validation

  • go test ./store
  • attempted frontend test with yarn test --runTestsByPath src/backend/HelmBackend.test.js --watchAll=false, but this repo has no test script in web/package.json
  • Alibaba Open Code Review was run after the change
  • verified this PR still contains exactly one commit on top of master

OCR Notes

OCR initially flagged that this PR mixed diagnostics with recommended values behavior. The recommended values files and js-yaml dependency were removed from this PR.

OCR also flagged credential redaction edge cases. This PR now covers userinfo redaction, common sensitive query keys, token-only userinfo fallback, malformed query fallback, and host:port false-positive avoidance.

OCR still recommends Go unit tests for the redaction helpers. The local repository publishing rule currently says not to upload *_test.go files, so no Go test file is included here.

Scope

This PR improves install diagnostics, error redaction, and stream-state coverage. It does not change chart default values, service exposure defaults, storage, DNS, ingress, or platform bootstrap behavior.

@bugkeep
bugkeep force-pushed the fix/app-store-install-diagnostics-upstream branch from 9d43a5f to 862e19b Compare July 8, 2026 15:53
@hsluoyz
hsluoyz merged commit 8a7b2cd into casosorg:master Jul 8, 2026
7 checks passed
@bugkeep
bugkeep deleted the fix/app-store-install-diagnostics-upstream branch August 19, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants