Skip to content

fix: repair Helm release upgrade flow - #142

Merged
hsluoyz merged 1 commit into
casosorg:masterfrom
bugkeep:fix/helm-release-upgrade-review
Aug 13, 2026
Merged

fix: repair Helm release upgrade flow#142
hsluoyz merged 1 commit into
casosorg:masterfrom
bugkeep:fix/helm-release-upgrade-review

Conversation

@bugkeep

@bugkeep bugkeep commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route Helm release upgrades through a dedicated SSE endpoint backed by action.NewUpgrade
  • preserve new chart defaults while reusing prior user overrides with ResetThenReuseValues
  • persist credential-free chart repository identity so existing releases can locate their chart repository during later upgrades
  • reload chart values when a legacy release is given its missing repository URL
  • restore diagnostic details for callers of the non-streaming upgrade endpoint
  • restore background upgrade tasks by exact chart, namespace, release, and operation identity
  • return exact chart name and version fields while retaining the legacy combined chart field for compatibility
  • add English and Chinese translations for the upgrade flow and remove superseded installation-only keys

Why

The Helm Releases page previously opened the install flow with an empty repository URL. The backend then attempted to fetch /index.yaml without a URL scheme, so releases could not be upgraded from this page.

Verification

  • go test ./... -tags skipCi -count=1
  • cd web && CI=true yarn react-scripts test --watchAll=false --runInBand (22 tests)
  • cd web && yarn run build
  • local regression verified that entering a repository URL for a legacy release reloads its values without allowing an older chart response to overwrite them
  • manually upgraded casos-test-nginx in the in-app browser: revision advanced from #2 to #3, remained deployed, and the repository URL stayed prefilled for the next upgrade

@bugkeep
bugkeep force-pushed the fix/helm-release-upgrade-review branch 2 times, most recently from dc4370c to 1d586a6 Compare August 10, 2026 15:24
@bugkeep
bugkeep force-pushed the fix/helm-release-upgrade-review branch from 1d586a6 to 2633388 Compare August 10, 2026 16:29
@hsluoyz
hsluoyz merged commit 29b98fe into casosorg:master Aug 13, 2026
7 checks passed
@bugkeep
bugkeep deleted the fix/helm-release-upgrade-review branch August 19, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants