Pass --unstable and --color always to fzf's default preview command
#1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass "--unstable" to the preview command for the chooser, so that recipe previews can work even when the justfile relies on unstable features, such as "!include" directives. Note that we're not taking the user by surprise by enabling unstable features in the preview: when the justfile includes unstable features, the user will need to pass "--unstable" explicitely to call "just --choose --unstable" already, or "just" will exit before launching the chooser.
Tell just to use colours in the recipe preview for the default chooser.
|
Nice, good change! Merging now. |
|
Thanks! |
casey
pushed a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
--unstableto the preview command for the chooser, so that recipe previews can work even when the justfile relies on unstable features, such as!includedirectives.Note that we're not taking the user by surprise by enabling unstable features in the preview: when the justfile includes unstable features, the user will need to pass
--unstableexplicitely to calljust --choose --unstablealready, orjustwill exit before launching the chooser.Also tell
just, in a second commit, to use colours for recipe previews.