Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renable install.sh test #1478

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Renable install.sh test #1478

merged 4 commits into from
Jan 5, 2023

Conversation

casey
Copy link
Owner

@casey casey commented Jan 5, 2023

No description provided.

@casey casey enabled auto-merge (squash) January 5, 2023 07:15
@casey
Copy link
Owner Author

casey commented Jan 5, 2023

@bloodearnest btw, I noticed that the install.sh test was flaky, it was failing when it hits the API to get the latest tag. I disabled it, but now I'm reenabling it with --tag 1.0.0, which would prevent hitting the API, just downloading the binary. It might wind up that in order for install.sh to not be flaky on Github Actions, you have to give it a tag. Not sure though, since I'm just reenabling it now.

@casey casey merged commit 45e633c into master Jan 5, 2023
@casey casey deleted the renable-install.sh-test branch January 5, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@casey