OS Recipe Attributes #1387
Merged
OS Recipe Attributes #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
force-pushed
the
os-specific-recipes
branch
from
2dd57e7
to
a20d27a
Compare
esiegel
approved these changes
Oct 29, 2022
|
|
||
| #[test] | ||
| fn to_str() { | ||
| assert_eq!(Attribute::NoExitMessage.to_str(), "no-exit-message"); |
There was a problem hiding this comment.
Maybe add the same test for all of the enums, though not sure if it tests much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
[linux],[macos],[windows], and[unix]recipe OS attributes.By default, without an OS attribute, a recipe is enabled on all operating systems. With an OS attribute, a recipe is only enabled when being run by a version of just build for that OS. Note that this depends on the OS the
justbinary was built for, not the OS that it's running on. So recipes with[linux]in a justfile run by ajustbinary built for Linux but running on the Windows Subsystem for Linux be enabled.This allows writing cross-platform justfiles by writing multiple recipes with the same name which are enabled on different OSes. For example:
On Windows,
just foowill printbarand on linuxjust foowill printbaz.Recipes with the
[unix]attribute are enabled on all unices, including Linux and MacOS.Todo: