Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't evaluate comments #1358

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Don't evaluate comments #1358

merged 2 commits into from
Oct 5, 2022

Conversation

casey
Copy link
Owner

@casey casey commented Oct 5, 2022

This is a follow-up to #1333. In addition to not printing out comments, it doesn't evaluate the contents of interpolations inside comments. @neunenak, what do you think?

@neunenak
Copy link
Contributor

neunenak commented Oct 5, 2022

Huh, I didn't realize interpolations inside comments would get evaluated. Yeah, this seems like a good change.

@casey
Copy link
Owner Author

casey commented Oct 5, 2022

Unfortunately they'll still get parsed, so you'll get parse errors. However, fixing that is a backwards-compatible change. However it'll be a little hairy. We'll have to either extract setting values in a first pass (not actually that hard since settings are simple) and use the settings to change how the parser works, or stipulate that the setting only affects parsing of recipes after the setting.

@casey casey merged commit cd09d1e into master Oct 5, 2022
@casey casey deleted the dont-evaluate-comments branch October 5, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants