Fix issues reported by clippy #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running clippy against just, the vast majority of the errors are:
```
error: the `Err`-variant returned from this function is very large
--> src/unresolved_recipe.rs:9:8
|
9 | ) -> CompileResult<'src, Recipe<'src>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes
|
= help: try reducing the size of `compile_error::CompileError<'src>`, for example by boxing large elements or replacing it with `Box<compile_error::CompileError<'src>>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
```
The large size of `CompileResult` is mostly caused by `CompileErrorKind`
being a large type within `CompileError`. So, Box-ing that type on
`CompileError` solves the `CompileResult` problem without requiring too
many additional code changes.
Most of the time, just will only be compiling one value of type
`CompileResult`, which will hopefully most of the time not even have the
error variant on it. So Boxing (part of) that variant in order to reduce
the size of `CompileResult`, which will get passed between many
different functions, makes sense.
|
How can I get these errors? When I run |
|
Huh, I just realized, I had my default toolchain set to nightly, not stable. It looks like these are all lints that are only reported on nightly clippy. |
|
I just tested it and this branch compiles and passes all tests on stable as well. |
|
Okay, sweet. I was worried I had something weird going on with the config. |
|
Actually, looking at these, they all look like reasonable fixes, so why not merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes every issue reported by running vanilla-configuration
cargo clippy.