Skip generating changelog in tests #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog generation requires annotating commits with a commit type, otherwise the tests will fail. This is annoying for contributors, since it's unusual, and I often myself forget to do it, causing a round-trip with tests. So, skip generating the changelog during the tests. Also, change the `--no-git` option for `gen book` and `gen all` to `--no-changelog`, so it's clearer what it does. I think I'll wind up just making a YAML file that contains commit types, for changelog generation, so it doesn't have to be done in the commit message. type: testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog generation requires annotating commits with a commit type,
otherwise the tests will fail. This is annoying for contributors, since
it's unusual, and I often myself forget to do it, causing a round-trip
with tests.
So, skip generating the changelog during the tests. Also, change the
--no-gitoption forgen bookandgen allto--no-changelog, soit's clearer what it does.
I think I'll wind up just making a YAML file that contains commit types,
for changelog generation, so it doesn't have to be done in the commit
message.
type: testing