Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check messages printed by imdl torrent create --input - #332

Closed
casey opened this issue Apr 5, 2020 · 1 comment
Closed

Check messages printed by imdl torrent create --input - #332

casey opened this issue Apr 5, 2020 · 1 comment
Labels

Comments

@casey
Copy link
Owner

casey commented Apr 5, 2020

No description provided.

@casey casey added the testing label Apr 5, 2020
@casey casey added this to the 0.1.0 milestone Apr 5, 2020
casey added a commit that referenced this issue Apr 6, 2020
If a user passes `--input foo`, print "Searching `foo` for files…",
instead of the resolved, absolute path to `foo`, since the former is
what the user typed in.

This was way harder, and had way more edge cases, than I thought it would
be!

One takaway, lexical path cleaning is excellent.

Fixes #332 and #252.
casey added a commit that referenced this issue Apr 6, 2020
If a user passes `--input foo`, print "Searching `foo` for files…",
instead of the resolved, absolute path to `foo`, since the former is
what the user typed in.

This was way harder, and had way more edge cases, than I thought it would
be!

One takaway, lexical path cleaning is excellent.

Fixes:
- #252
- #332
casey added a commit that referenced this issue Apr 6, 2020
If a user passes `--input foo`, print "Searching `foo` for files…",
instead of the resolved, absolute path to `foo`, since the former is
what the user typed in.

This was way harder, and had way more edge cases, than I thought it would
be!

One takaway, lexical path cleaning is excellent.

Fixes:
- #252
- #332
casey added a commit that referenced this issue Apr 6, 2020
If a user passes `--input foo`, print "Searching `foo` for files…",
instead of the resolved, absolute path to `foo`, since the former is
what the user typed in.

This was way harder, and had way more edge cases, than I thought it would
be!

One takaway, lexical path cleaning is excellent.

Fixes:
- #252
- #332
@casey
Copy link
Owner Author

casey commented Apr 6, 2020

Fixed in #334.

@casey casey closed this as completed Apr 6, 2020
casey added a commit that referenced this issue Apr 8, 2020
If a user passes `--input foo`, print "Searching `foo` for files…",
instead of the resolved, absolute path to `foo`, since the former is
what the user typed in.

This was way harder, and had way more edge cases, than I thought it would
be!

One takaway, lexical path cleaning is excellent.

type: changed
fixes:
- #252
- #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant