Reconstructed file validation fix #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated example to remove base64 type for dataPayload and to use a shared dataset - specifically the cutty-sark.jpg file fragments in NIST's File Carving image graphic-disorder_1305121235.dd (https://www.nist.gov/itl/ssd/software-quality-group/computer-forensics-tool-testing-program-cftt/cftt-technical-0)
Added drafting RecoveredObject properties.
Created repaired JPEG example using shared dataset NIST File Carving graphic-braid_1305121235.dd
Updated to describe revised examples.
Corrected fragment sizes in bytes.
Added dd command line reconstruction of cutty-sark.jpg from NIST File Carving image graphic-disorder_1305121235.dd
This had a collision with recent UUID fixes done in PR 103. I resolved the conflict by just selecting the state in the `reconstructed_file_validation_fix`, as 103 appeared to be a set of effects that avoided altering semantics of the content, whereas `reconstructed_file_validation_fix` implemented content fixes as well. A follow-on patch will regenerate Make-managed files. References: * #103
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
approved these changes
Sep 1, 2022
Member
ajnelson-nist
left a comment
ajnelson-nist
left a comment
There was a problem hiding this comment.
I'm fine with this merging once CI passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.