Skip to content

Conversation

@j-f1
Copy link

@j-f1 j-f1 commented Feb 6, 2017

Deprecated properties aren’t added.

@casesandberg
Copy link
Owner

I don't understand why you are adding all of the exports to the default export. Can you provide some information around why you want to make this change?

@j-f1
Copy link
Author

j-f1 commented Mar 6, 2017

@casesandberg I feel it’s easier and clearer to do

import reactCSS from 'reactcss'
// ...
Component = reactCSS.hover(Component)

than

import reactCSS, { hover } from 'reactcss'
// ...
Component = hover(Component)
// Where did `hover` come from? Did I override it by accident somewhere?

@casesandberg
Copy link
Owner

The later is the cleaner way to do imports with es6, however. If you want them attached to the reactCSS var you can always do:

import { * as reactCSS } from 'reactCSS'

@j-f1
Copy link
Author

j-f1 commented Mar 6, 2017

Then how would I use the default export? (reactCSS({ ... }))

@j-f1
Copy link
Author

j-f1 commented May 24, 2017

@casesandberg Any updates?

@j-f1
Copy link
Author

j-f1 commented Jan 5, 2018

Ping @casesandberg?

@quagliero
Copy link
Contributor

@j-f1 Check the index file (https://github.com/casesandberg/reactcss/blob/master/src/index.js), the default export just exports the named ReactCSS function.

import * as rcss from 'reactcss';

rcss.ReactCSS({ ... });

@j-f1 j-f1 closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants