Merged
Conversation
tnm
force-pushed
the
fix/multi-source-app-crash
branch
2 times, most recently
from
2ecc01e to
7b9ec81
Compare
- Add null checks for app.spec.source to prevent UI crash - Add support for displaying multi-source applications (spec.sources[]) - Update ApplicationSpec type to include optional sources array - Add defensive-checks.test.ts with test coverage Multi-source apps now show all repositories in the detail view sidebar, and show the first repo "+N more" in the card view. Fixes #53
tnm
force-pushed
the
fix/multi-source-app-crash
branch
from
7b9ec81 to
a228ebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.spec.sourceto prevent UI crash when encountering multi-source applicationsspec.sources[]instead ofspec.source, causing the UI to crash with "can't access property repoURL, e.spec.source is undefined"Changes
src/components/-applications/application-card.tsx- Wrap repository section in conditional checksrc/routes/_authenticated/applications.$name.tsx- Wrap repository section and use optional chaining for targetRevisionsrc/lib/defensive-checks.test.ts- Add tests for defensive null check patternsTest plan
Fixes #53