Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add critcmp & insert into adapter before model #77

Merged
merged 3 commits into from
Apr 5, 2020

Conversation

GopherJ
Copy link
Member

@GopherJ GopherJ commented Apr 5, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.05%.
The diff coverage is 77.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   80.52%   80.46%   -0.06%     
==========================================
  Files          18       18              
  Lines        2691     2693       +2     
==========================================
  Hits         2167     2167              
- Misses        524      526       +2     
Impacted Files Coverage Δ
src/adapter/file_adapter.rs 47.91% <ø> (ø)
src/rbac_api.rs 83.98% <ø> (ø)
src/enforcer.rs 80.93% <33.33%> (-2.17%) ⬇️
src/internal_api.rs 40.21% <90.62%> (-1.84%) ⬇️
src/adapter/memory_adapter.rs 37.17% <100.00%> (+2.11%) ⬆️
src/effector.rs 70.58% <100.00%> (ø)
src/model/default_model.rs 94.52% <100.00%> (+0.07%) ⬆️
src/config.rs 92.15% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773a1d1...0339214. Read the comment docs.

@GopherJ
Copy link
Member Author

GopherJ commented Apr 5, 2020

Screenshot_2020-04-05 Job #270 - casbin casbin-rs - Travis CI
seems critcmp doesn't work yet.

@GopherJ
Copy link
Member Author

GopherJ commented Apr 5, 2020

image
Now it shows up

@GopherJ GopherJ merged commit 0cd4e88 into casbin:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant