Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply new error type to enforcer,model,config... #39

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

GopherJ
Copy link
Member

@GopherJ GopherJ commented Jan 2, 2020

No description provided.

@GopherJ
Copy link
Member Author

GopherJ commented Jan 2, 2020

try to resolve #24

@GopherJ
Copy link
Member Author

GopherJ commented Jan 2, 2020

@hsluoyz @xcaptain could you review it?

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #39 into master will increase coverage by 1.53%.
The diff coverage is 82.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #39      +/-   ##
=========================================
+ Coverage   85.16%   86.7%   +1.53%     
=========================================
  Files          12      12              
  Lines        1861    1895      +34     
=========================================
+ Hits         1585    1643      +58     
+ Misses        276     252      -24
Impacted Files Coverage Δ
src/error.rs 0% <0%> (ø)
src/rbac/default_role_manager.rs 92.55% <0%> (-0.44%) ⬇️
src/rbac_api.rs 85.26% <100%> (+0.76%) ⬆️
src/management_api.rs 90.47% <100%> (ø) ⬆️
src/adapter/file_adapter.rs 50% <16.66%> (-3.49%) ⬇️
src/enforcer.rs 85.19% <73.42%> (+10.67%) ⬆️
src/config.rs 84.86% <80%> (+1.2%) ⬆️
src/model.rs 94.52% <91.9%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960d9bc...b7ceeeb. Read the comment docs.

@hsluoyz hsluoyz merged commit 3a94869 into casbin:master Jan 2, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Jan 2, 2020

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants