Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve "Share" button with engine selection and clipboard support, improve i18n #188

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

HashCookie
Copy link
Contributor

@HashCookie HashCookie commented Jan 4, 2025

Fix: #187

Reason

Resolve

  1. Remove unused useCopy hook and implement new clipboard functionality
  2. Add engine selection to share data structure
  3. Integrate selected engine type into share URL parameters

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for casbin-editor ready!

Name Link
🔨 Latest commit 2b7e4a4
🔍 Latest deploy log https://app.netlify.com/sites/casbin-editor/deploys/6778ee233a578d00088a6de9
😎 Deploy Preview https://deploy-preview-188--casbin-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hsluoyz hsluoyz changed the title fix: Improve share functionality with engine selection and clipboard support feat: Improve "Share" button with engine selection and clipboard support, improve i18n Jan 4, 2025
@hsluoyz hsluoyz merged commit 0b0f8ae into casbin:master Jan 4, 2025
10 of 11 checks passed
@hsluoyz
Copy link
Member

hsluoyz commented Jan 4, 2025

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HashCookie HashCookie deleted the improve-share-ux branch January 4, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants