fix: ensure that shared content loads correctly under the basic model, fix bug introduced by PR: #169 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for casbin-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hsluoyz
changed the title
|
🎉 This PR is included in version 1.25.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced by PR: #169
Description:
When users modify content while using the
basic(ACL) model and generate a share link, there is an issue where the content does not update when opening this link.Reason:
In the original code,
useEffectonly depends onmodelKind. If the shared content uses thebasicmodelKind, it will not trigger an update ofuseEffect, resulting in the data forenforceContextbeing unable to be passed through the sharing link.Resolve:
Add a
triggerUpdatestate counter and include it in theuseEffectdependencies to force content updates.