Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove "syntax validate" button, add toast message to run button #170

Merged
merged 8 commits into from
Nov 29, 2024
Merged

feat: remove "syntax validate" button, add toast message to run button #170

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83c377d
chore: update casbin dependency to version 5.36.0
HashCookie Nov 22, 2024
b3a488b
Merge branch 'casbin:master' into master
HashCookie Nov 22, 2024
16f882b
Merge branch 'casbin:master' into master
HashCookie Nov 25, 2024
d0a302d
style: add color classes to status messages in editor hooks
HashCookie Nov 27, 2024
57da8c9
feat: add content loading state to EditorScreen component
HashCookie Nov 27, 2024
3fe49c3
feat: add toast notifications for user feedback in editor component
HashCookie Nov 28, 2024
bcfaba4
feat: enhance editor response handling and error notifications
HashCookie Nov 28, 2024
bd99c65
refactor: remove syntax validation button and related translations
HashCookie Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: enhance editor response handling and error notifications
  • Loading branch information
@HashCookie
HashCookie committed Nov 28, 2024
commit bcfaba4643aca92aeeb72d9ec7370f130b3f8fa0
12 changes: 10 additions & 2 deletions app/components/editor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,15 @@ export const EditorScreen = () => {
customConfig,
request,
enforceContextData,
onResponse: (v) => {
onResponse: (v: JSX.Element | any[]) => {
if (isValidElement(v)) {
setEcho(v);
const props = (v as any).props;
if (props.className?.includes('text-red-500')) {
const errorMessage = props.children;
toast.error(errorMessage);
setRequestResult(errorMessage);
}
} else if (Array.isArray(v)) {
const formattedResults = v.map((res) => {
if (typeof res === 'object') {
Expand All @@ -454,7 +460,9 @@ export const EditorScreen = () => {
});
const result = formattedResults.join('\n');
setRequestResult(result);
toast.success(`Test completed`);
if (result && !result.includes('error')) {
toast.success('Test completed successfully');
}
}
},
});
Expand Down