fix: Ensure tab characters in policy files are parsed as white-space #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagilio please review |
|
|
|
@janpieterz plz add the unit test, thx! |
|
@hsluoyz sorted! |
|
@janpieterz fix:
|
|
@hsluoyz should be fixed now |
|
@janpieterz the benchmark CI is too slow. Can you remove it?
|
|
@hsluoyz you mean remove it from running as a pull request check? |
|
@janpieterz remove |
|
Sure, done here |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the policy file has tabs in it, the change to use the CSV parser meant that the policies were parsed incorrect.
I have a unit test that proves this that I can add if wanted (seems very low level but might be good to ensure regressions).