feat: Support batch enforce and add corresponding test. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagilio please review |
sagilio
reviewed
Aug 5, 2022
AsakusaRinne
force-pushed
the
add_batch_enforce
branch
from
2919c49
to
c107068
Compare
|
@AsakusaRinne fix:
|
AsakusaRinne
force-pushed
the
add_batch_enforce
branch
from
c107068
to
e920931
Compare
AsakusaRinne
force-pushed
the
add_batch_enforce
branch
from
e920931
to
ab645e5
Compare
|
🎉 This PR is included in version 2.0.0-preview.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support batch enforce and add corresponding test. #166
It used async stream to implement
BatchEnforceAsyncexceptNET452.It added
BatchEnforceParallelinEnforcerwithout a corresponding interface inIEnforcer. I'm not sure about the design here. What I think is that its only a special implementation so that adding it toIEnforcermay mean little.As for the extension, I only provide methods which accept generic type inherited from
IRequestValues. The reason is that if I provide similar API with that ofEnforceExtension.GenericEnforce, users need to pass severalIEnumerable, such ase.BatchEnforce(List<T1>, List<T2>, List<T3>). Thus, consistency of the parameters is not actually ensured, which I think may not be a good practice. Please give some suggestions about it.I'll PR a benchmark of it if the design is approved finally.