feat: Add priority sort with subject hierarchy. #259
Conversation
|
@sagilio @xcaptain @huazhikui please review |
|
@sagilio @xcaptain @huazhikui please review |
|
It's a draft PR and has not been well implemented yet. Though it could pass the existing test cases, the way to implement it needs to be optimized. Of course, thank you for any advice if you'd like to review it now. |
AsakusaRinne
force-pushed
the
preview
branch
2 times, most recently
from
b3f3f04 to
2bb1d98
Compare
Casbin/Model/DefaultModel.cs
Outdated
|
|
||
| private string GetNameWithDomain(string domain, string name) | ||
| { | ||
| return domain + "::" + name; |
There was a problem hiding this comment.
Is there any way to avoid using a default Separator ::?
There was a problem hiding this comment.
Maybe we could create a new class for it to describe the NameWithDomain?
|
🎉 This PR is included in version 2.0.0-preview.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fix: #238
What does it solve
It sync the feature of golang version which is described here.
What does it change
It add a new EffectType named "PriorityAllOverride" and some new methods. The way of implementation needs to be optimized.