Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build arg in Dockerfile #375

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented May 30, 2023

Fixes: #359

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
@praveenrewar praveenrewar requested a review from neil-hickey May 30, 2023 18:23
Copy link

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@neil-hickey neil-hickey merged commit 650d4c5 into carvel-dev:develop Jun 2, 2023
@sethiyash
Copy link
Contributor

/cherry-pick v0.13.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 20, 2023
@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jun 20, 2023
sethiyash added a commit that referenced this pull request Jun 20, 2023
Merge pull request #375 from praveenrewar/update-dockerfile

Fix build arg in Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

arm64 support for secretgen-controller
3 participants