Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping golang 1.20.3 and golint changes #743

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

sethiyash
Copy link
Contributor

What this PR does / why we need it:

Bumping go to 1.20.3 to fix the CVE's in go 1.19.6

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@sethiyash sethiyash requested a review from praveenrewar May 3, 2023 12:41
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: sethiyash <yashsethiya97@gmail.com>
@sethiyash sethiyash merged commit 5770b80 into develop May 4, 2023
@praveenrewar praveenrewar deleted the bump-go-1.20.3 branch May 29, 2023 21:09
@praveenrewar praveenrewar mentioned this pull request May 29, 2023
5 tasks
@sethiyash
Copy link
Contributor Author

/cherry-pick v0.55.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 12, 2023
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Jun 12, 2023
sethiyash added a commit that referenced this pull request Jun 12, 2023
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Co-authored-by: Yash Sethiya <yashsethiya97@gmail.com>
@sethiyash
Copy link
Contributor Author

/cherry-pick v0.54.x
/cherry-pick v0.53.x

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 5770b806d63a3557096b77eee6df007aef5a2982 into temp-cherry-pick-cd7349-v0.54.x

@sethiyash
Copy link
Contributor Author

/cherry-pick v0.54.x

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 5770b806d63a3557096b77eee6df007aef5a2982 into temp-cherry-pick-cd7349-v0.54.x

sethiyash added a commit that referenced this pull request Jun 14, 2023
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
kumaritanushree pushed a commit that referenced this pull request Jun 14, 2023
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
sethiyash added a commit that referenced this pull request Jun 15, 2023
* Bumping golang 1.20.3 and golint changes (#743)

Signed-off-by: sethiyash <yashsethiya97@gmail.com>

* Bumping Go version to 1.20.4 (#759)

Signed-off-by: sethiyash <yashsethiya97@gmail.com>

* Bumping go version to 1.20.5 (#763)

Signed-off-by: sethiyash <yashsethiya97@gmail.com>

* making go lint happy

Signed-off-by: sethiyash <yashsethiya97@gmail.com>

---------

Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants