-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove go tidy from release step #732
Conversation
Bump goreleaser to the latest version Signed-off-by: João Pereira <joaod@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙏🏻
Since we are planning to replicate this for other tools, should we test this on a fork once? (Ignore if already done)
Signed-off-by: João Pereira <joaod@vmware.com>
f951621
to
dbba784
Compare
LGTM. Want to understand why we removed |
When we are releasing our tools we want to make sure nothing changes. That is why we are removing those 2 steps |
LGTM |
* Remove go tidy from release step Bump goreleaser to the latest version Signed-off-by: João Pereira <joaod@vmware.com> * Specify the tag being used for a release Signed-off-by: João Pereira <joaod@vmware.com> --------- Signed-off-by: João Pereira <joaod@vmware.com>
* Remove go tidy from release step Bump goreleaser to the latest version Signed-off-by: João Pereira <joaod@vmware.com> * Specify the tag being used for a release Signed-off-by: João Pereira <joaod@vmware.com> --------- Signed-off-by: João Pereira <joaod@vmware.com>
/cherry-pick v0.53.x |
Cherry-pick failed with |
* Remove go tidy from release step Bump goreleaser to the latest version Signed-off-by: João Pereira <joaod@vmware.com> * Specify the tag being used for a release Signed-off-by: João Pereira <joaod@vmware.com> --------- Signed-off-by: João Pereira <joaod@vmware.com>
Remove go tidy from release step (#732)
* Remove go tidy from release step Bump goreleaser to the latest version Signed-off-by: João Pereira <joaod@vmware.com> * Specify the tag being used for a release Signed-off-by: João Pereira <joaod@vmware.com> --------- Signed-off-by: João Pereira <joaod@vmware.com>
Bump goreleaser to the latest version